Allow simple expansion variables to start with a number #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgood
added a commit
that referenced
this pull request
Jan 24, 2024
Verify the current behavior of bracketed numeric names, and an example test case for simple names in preparation for #4.
mgood
requested changes
Jan 24, 2024
There was a problem hiding this comment.
Thanks, this is a good start, but it looks like it will parse any mix of numbers and letters as a name, but if the name starts with a number it can only contain numbers. See my comments inline for an example.
I pushed 256a914 to double-check how numeric names were handled in bracket expressions, along with a test case for simple numeric names to verify that they're consistent.
mgood
reviewed
Jan 24, 2024
Added tests for numbered expansion variables. Fixed a formatting verb for `p.op` rune.
Removed unecessary test function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3
Added tests for numbered expansion variables and fixed a formatting verb for
p.oprune.